Use make_client instead of calling HTTP::Client
#4709
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using `make_client` to create `HTTP::Client`, allows for a simple way to easily add logic to all `HTTP::Client` initialized within Invidious.
Co-authored-by: ChunkyProgrammer <[email protected]>
SamantazFox
reviewed
Jun 16, 2024
| @@ -45,24 +42,22 @@ struct YoutubeConnectionPool | |||
|
|
|||
| private def build_pool | |||
| DB::Pool(HTTP::Client).new(initial_pool_size: 0, max_pool_size: capacity, max_idle_pool_size: capacity, checkout_timeout: timeout) do | |||
| conn = HTTP::Client.new(url) | |||
| conn.family = CONFIG.force_resolve | |||
| conn = make_client(url, force_resolve = true) | |||
There was a problem hiding this comment.
It should be that, btw:
Suggested change
| conn = make_client(url, force_resolve = true) | |
| conn = make_client(url, force_resolve: true) |
I don't understand why the = isn't flagged by the compiler as invalid syntax.
There was a problem hiding this comment.
So, from a quick discussion in the Crystal matrix room, doing
make_client(url, foo = true)is the same as doing
foo = true
make_client(url, foo)i.e it assigns the value to a local variable and then passes that variable as a positional function parameter. In this case, this would be end up being assigned to region.
There was a problem hiding this comment.
Oops thanks!
I guess that also explains why this wasn't caught my the CI #4709 (comment)
There was a problem hiding this comment.
Yep! I've opened an issue at the Crystal bug tracker, because it seems like something that shouldn't be allowed by design: crystal-lang/crystal#14722
Co-authored-by: Samantaz Fox <[email protected]>
SamantazFox
reviewed
Jun 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is mostly so that we can customize the client Invidious uses for all HTTP requests. For example, to config a HTTP proxy to use.
I left
images.cruntouched as to not conflict with #4326