Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Player: Fix video playback for videos already watched videos. #4731

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Fijxu
Copy link

@Fijxu Fijxu commented Jun 5, 2024

Trying to watch an already watched video will make the video start 15 seconds before the end of the video. This is not very comfortable when listening to music or watching/listening playlists over and over. This can be easily tested on any instance with the "Save playback position" enabled on Preferences.

@Fijxu Fijxu requested a review from a team as a code owner June 5, 2024 15:35
@Fijxu Fijxu requested review from SamantazFox and removed request for a team June 5, 2024 15:35
assets/js/player.js Outdated Show resolved Hide resolved
Trying to watch an already watched video will make the video start 15
seconds before the end of the video. This is not very comfortable when
listening to music or watching/listening playlists over and over.
@SamantazFox SamantazFox added need-testing This feature needs to be deployed and tested to see if it's working, and doesn't break something in-testing This feature has been deployed and is being tested and removed need-testing This feature needs to be deployed and tested to see if it's working, and doesn't break something labels Jun 16, 2024
@pimlie
Copy link

pimlie commented Jun 26, 2024

Thanks for the fix. Wdyt about listening on the player ended event to reset the play position? Might be a bit cleaner solution then using a fixed threshold, but not sure how/where the playback position is recorded though and if there is an api endpoint available for that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in-testing This feature has been deployed and is being tested
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants