-
Notifications
You must be signed in to change notification settings - Fork 108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for live photos #208
base: master
Are you sure you want to change the base?
Conversation
Hello @qlyoung. That's wonderful addition to the software. Please add unit tests to the PR and I will happily merge it. |
Sweet! I figured i'd make sure it was wanted before bothering with tests. Will do
…On Wed, Aug 30, 2023, at 3:46 AM, Ivan Dokov wrote:
Hello @qlyoung <https://github.com/qlyoung>. That's wonderful addition to the software. Please add unit tests to the PR and I will happily merge it.
—
Reply to this email directly, view it on GitHub <#208 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ABUCX66K4C5N633H2XCVWX3XX3VU5ANCNFSM6AAAAAA4D5B2HE>.
You are receiving this because you were mentioned.Message ID: ***@***.***>
|
@qlyoung Any progress on this? It is a feature I would like to have. Just a sidenote from spending the morning writing phockup test code: if you are using vscode for development, the pytest fixture is not compatible with |
Look for MediaGroupUUID and ContentIdentifier EXIF tags. These are present in media files which are part of live photo pairs. If found, any future files with the same UUID are named the same as the first one and placed in the same directory. With this change, live photos and their associated .mov files are moved together.
No progress on writing tests. I haven't found time to sit down and learn this project's testing setup. I went ahead and pushed the latest version of this change though, so if you care to build it yourself, the code is in the branch referenced by this PR |
I think this is what's needed:
Note that the test highlights that the second file gets renamed to match the first, but I think this is as desired. |
Look for MediaGroupUUID and ContentIdentifier EXIF tags. These are present in media files which are part of live photo pairs. If found, any future files with the same UUID are named the same as the first one and placed in the same directory.
With this change, live photos and their associated .mov files are moved together.