Refactored POMs towards consistency#106
Open
dashorst wants to merge 6 commits into
Open
Conversation
All duplicate information was moved to the parent pom, the description of the parent POM is no longer the same as the Wicket CDI module. All dependency information is now centralized in the parent POM, including the plugins necessary for building. I've included the enforcer plugin for consistent POM layout (which is annoying, but helps in the end for enforcing a single style across all project modules). All plugins now use their most recent version.
Wicket dependency -> 7.0.0, Java level to 1.7 (minimum for Wicket), json to most recent Java 1.7 compatible version, fixed compilation errors. Also added logback for logging during testing. Is an optional dependency that doesn't require any configuration to spew out logging.
Wicket dependency -> 7.0.0, Java level to 1.7 (minimum for Wicket), json to most recent Java 1.7 compatible version, fixed compilation errors. Also added logback for logging during testing. Is an optional dependency that doesn't require any configuration to spew out logging.
Wicket dependency -> 7.0.0, Java level to 1.7 (minimum for Wicket), json to most recent Java 1.7 compatible version, fixed compilation errors. Also added logback for logging during testing. Is an optional dependency that doesn't require any configuration to spew out logging.
Wicket dependency -> 7.0.0, Java level to 1.7 (minimum for Wicket), json to most recent Java 1.7 compatible version, fixed compilation errors. Also added logback for logging during testing. Is an optional dependency that doesn't require any configuration to spew out logging.
Source jar is now generated when releasing, and the examples war is no longer deployed to Maven central.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request fixes the compatibility between Select 2 and Wicket 7. In order to fix the dependencies
I've also made the POMs consistent.