Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding possibility of completing mime-type by dataproduct_type parameter #43

Closed
wants to merge 2 commits into from

Conversation

Bonnarel
Copy link
Contributor

@Bonnarel Bonnarel commented May 5, 2020

The pull request adds in the content_type subsection the possibility to add a parameter in the mime-type in order to type the dataproduct retrieved by the link. This is related to issue #42. the proposal is to uses the parameter "dataproduct_type" and to reuse standard lists of values (for that, ObsCore, Vocabulary WG)

@msdemlei
Copy link
Collaborator

msdemlei commented May 5, 2020

A couple of comments:

(a) Please don't have lines longer than 72 characters -- it spoils the
diffs and will lead to unnecessary conflicts.

(b) I'm always unhappy with "may" in specs. I'd say we should be clear
under which circumstances the product type helps clients (and,
frankly, I don't have language to propose here just yet), and then say
people should (or perhaps "are strongly encouraged to foster useful
interaction with client programmes") have the media type parameter.

(c) Just cite the vocabulary as it is now; so, I'd say it should just
be: "The values of the dataproduct_type parameters must be taken from
the IVOA vocabulary \url{http://www.ivoa.net/rdf/dataproduct_type}."

(d) I'd say as a matter of courtesy, the change of the makefile should
be taken out of the PR.

@Bonnarel
Copy link
Contributor Author

Bonnarel commented May 5, 2020 via email

@Bonnarel
Copy link
Contributor Author

Bonnarel commented May 5, 2020

Changes made following Markus comments

@pdowler
Copy link
Collaborator

pdowler commented May 5, 2020

The issue is still marked TBD and I thought we would confirm going ahead with this at the session. I am fine with it personally...

@msdemlei
Copy link
Collaborator

So... prompted by Norman I've made the mistake of actually reading RFC
2045, which, on the topic of media type parameters says this:

"""
The set of meaningful parameters depends on the media type and
subtype. Most parameters are associated with a single specific
subtype. However, a given top-level media type may define parameters
which are applicable to any subtype of that type. Parameters may be
required by their defining content type or subtype or they may be
optional. MIME implementations must ignore any parameters whose names
they do not recognize.

For example, the "charset" parameter is applicable to any subtype of
"text", while the "boundary" parameter is required for any subtype of
the "multipart" media type.

There are NO globally-meaningful parameters that apply to all media
types. Truly global mechanisms are best addressed, in the MIME
model, by the definition of additional Content-* header fields.
"""

While I would yet allow that the "meaningful" up there may not entirely
preclude the use of ad-hoc parameters, I think the rest of this text
makes it very clear that you're not supposed to just add parameters
willy-nilly.

Datalink already is in trouble because of the content="datalink" clause,
but then that's modifying x-votable+xml. so, disregarding the little
scandal that we've been using a non-standard media type for decades we
at least could legalise that (and the serialization parameter from
VOTable itself) if we ever define a proper VOTable media type.

If, on the other hand, we now add parameters to essentially all other
media types, most of which are totally not under our control, I'd say we
shouldn't do it. It's just too much of a violation of RFC 2045.

And certainly if we did this, it can't happen based on a github
discussion -- it needs to go the mailing list.

@pdowler
Copy link
Collaborator

pdowler commented May 28, 2020

Add a new field to links response (name: dataproduct_type? content_qualifier?) for a vocabulary term (use case: data product type vocab). Optional column in 1.1, maybe mandatory later.

@Bonnarel Bonnarel closed this Sep 8, 2021
@Bonnarel
Copy link
Contributor Author

Bonnarel commented Sep 8, 2021

replaced by PR #56 (DataLink-#51)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants