-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
adding possibility of completing mime-type by dataproduct_type parameter #43
Conversation
A couple of comments: (a) Please don't have lines longer than 72 characters -- it spoils the (b) I'm always unhappy with "may" in specs. I'd say we should be clear (c) Just cite the vocabulary as it is now; so, I'd say it should just (d) I'd say as a matter of courtesy, the change of the makefile should |
Hi markus
Le 05/05/2020 à 15:23, msdemlei a écrit :
A couple of comments:
(a) Please don't have lines longer than 72 characters -- it spoils the
diffs and will lead to unnecessary conflicts.
OK Sorry. Will fix this after the email
(b) I'm always unhappy with "may" in specs. I'd say we should be clear
under which circumstances the product type helps clients (and,
frankly, I don't have language to propose here just yet), and then say
people should (or perhaps "are strongly encouraged to foster useful
interaction with client programmes") have the media type parameter.
Hum!. Only when the link is a dataproduct. This parameter is useless for
documentation and may be for #proc. or auxliary.
(c) Just cite the vocabulary as it is now; so, I'd say it should just
be: "The values of the dataproduct_type parameters must be taken from
the IVOA vocabulary \url{http://www.ivoa.net/rdf/dataproduct_type}
<http://www.ivoa.net/rdf/dataproduct_type%7D>."
Well if the dataproduct_type vocabulary is a recom and still is
consistent with ObsCore we can do that
(d) I'd say as a matter of courtesy, the change of the makefile should
be taken out of the PR.
OK
Cheers
François
… —
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#43 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AMP5LTCB7N6RHKF4EG2YYYTRQAHNBANCNFSM4MZRLSSQ>.
|
Changes made following Markus comments |
The issue is still marked TBD and I thought we would confirm going ahead with this at the session. I am fine with it personally... |
So... prompted by Norman I've made the mistake of actually reading RFC """ For example, the "charset" parameter is applicable to any subtype of There are NO globally-meaningful parameters that apply to all media While I would yet allow that the "meaningful" up there may not entirely Datalink already is in trouble because of the content="datalink" clause, If, on the other hand, we now add parameters to essentially all other And certainly if we did this, it can't happen based on a github |
Add a new field to links response (name: dataproduct_type? content_qualifier?) for a vocabulary term (use case: data product type vocab). Optional column in 1.1, maybe mandatory later. |
The pull request adds in the content_type subsection the possibility to add a parameter in the mime-type in order to type the dataproduct retrieved by the link. This is related to issue #42. the proposal is to uses the parameter "dataproduct_type" and to reuse standard lists of values (for that, ObsCore, Vocabulary WG)