-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Alternative Field Encoding for Types #33
Conversation
@Doreen-Schwartz The interface changes look good! Please proceed with the rest of the implementation. |
I've added in unit tests + the requested changes. I think it's also worth adding this feature somewhere in the README, but I wasn't sure where would be most appropriate. |
@Doreen-Schwartz The PR looks really good! Thank you for the unit tests. |
@ivosh Thank you for the review. I've added a commit with a correction based on your comment |
@Doreen-Schwartz Please could you fix the formatting problem reported by |
@ivosh Fixed! |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #33 +/- ##
==========================================
+ Coverage 96.52% 96.59% +0.06%
==========================================
Files 10 10
Lines 778 793 +15
Branches 230 235 +5
==========================================
+ Hits 751 766 +15
- Misses 26 27 +1
+ Partials 1 0 -1 ☔ View full report in Codecov by Sentry. |
@ivosh Thanks for merging the PR! When can I expect this feature to be released onto npm so it can be used in my project? |
I am currently working on upgrading dependencies and updating README. |
Changes
informationWriter
) to each Field fornistEncode
.informationDecoder
) to each Field fornistDecode
.