fix(ios): replace UIGraphicsBeginImageContext in Compression.m
#2055
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-merge-queue bot
referenced
this pull request
in valora-inc/wallet
Jul 23, 2024
#5607) [](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [react-native-image-crop-picker](https://togithub.com/ivpusic/react-native-image-crop-picker) | [`^0.40.3` -> `^0.41.2`](https://renovatebot.com/diffs/npm/react-native-image-crop-picker/0.40.3/0.41.2) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>ivpusic/react-native-image-crop-picker (react-native-image-crop-picker)</summary> ### [`v0.41.2`](https://togithub.com/ivpusic/react-native-image-crop-picker/releases/tag/v0.41.2) [Compare Source](https://togithub.com/ivpusic/react-native-image-crop-picker/compare/v0.41.1...v0.41.2) #### What's Changed - Fixes an issue that would cause the compiler to crash in Xcode 16 beta1 by [@​isnine](https://togithub.com/isnine) in [https://github.com/ivpusic/react-native-image-crop-picker/pull/2068](https://togithub.com/ivpusic/react-native-image-crop-picker/pull/2068) #### New Contributors - [@​isnine](https://togithub.com/isnine) made their first contribution in [https://github.com/ivpusic/react-native-image-crop-picker/pull/2068](https://togithub.com/ivpusic/react-native-image-crop-picker/pull/2068) **Full Changelog**: ivpusic/react-native-image-crop-picker@v0.41.1...v0.41.2 ### [`v0.41.1`](https://togithub.com/ivpusic/react-native-image-crop-picker/releases/tag/v0.41.1) [Compare Source](https://togithub.com/ivpusic/react-native-image-crop-picker/compare/v0.41.0...v0.41.1) #### What's Changed - URGENT: Updated RNImageCropPicker.podspec by [@​ShivamKJJW](https://togithub.com/ShivamKJJW) in [https://github.com/ivpusic/react-native-image-crop-picker/pull/2056](https://togithub.com/ivpusic/react-native-image-crop-picker/pull/2056) #### New Contributors - [@​ShivamKJJW](https://togithub.com/ShivamKJJW) made their first contribution in [https://github.com/ivpusic/react-native-image-crop-picker/pull/2056](https://togithub.com/ivpusic/react-native-image-crop-picker/pull/2056) **Full Changelog**: ivpusic/react-native-image-crop-picker@v0.41.0...v0.41.1 ### [`v0.41.0`](https://togithub.com/ivpusic/react-native-image-crop-picker/releases/tag/v0.41.0) [Compare Source](https://togithub.com/ivpusic/react-native-image-crop-picker/compare/v0.40.3...v0.41.0) #### What's Changed - fix(ios): replace `UIGraphicsBeginImageContext` in Compression.m by [@​remarkablemark](https://togithub.com/remarkablemark) in [https://github.com/ivpusic/react-native-image-crop-picker/pull/2055](https://togithub.com/ivpusic/react-native-image-crop-picker/pull/2055) - Add Privacy manifest by [@​ujeon](https://togithub.com/ujeon) in [https://github.com/ivpusic/react-native-image-crop-picker/pull/2045](https://togithub.com/ivpusic/react-native-image-crop-picker/pull/2045) - add Dutch (nl) as a translation for iOS by [@​HostenMarijn](https://togithub.com/HostenMarijn) in [https://github.com/ivpusic/react-native-image-crop-picker/pull/1918](https://togithub.com/ivpusic/react-native-image-crop-picker/pull/1918) #### New Contributors - [@​remarkablemark](https://togithub.com/remarkablemark) made their first contribution in [https://github.com/ivpusic/react-native-image-crop-picker/pull/2055](https://togithub.com/ivpusic/react-native-image-crop-picker/pull/2055) - [@​ujeon](https://togithub.com/ujeon) made their first contribution in [https://github.com/ivpusic/react-native-image-crop-picker/pull/2045](https://togithub.com/ivpusic/react-native-image-crop-picker/pull/2045) - [@​HostenMarijn](https://togithub.com/HostenMarijn) made their first contribution in [https://github.com/ivpusic/react-native-image-crop-picker/pull/1918](https://togithub.com/ivpusic/react-native-image-crop-picker/pull/1918) **Full Changelog**: ivpusic/react-native-image-crop-picker@v0.40.3...v0.41.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - "after 5pm,every weekend" in timezone America/Los_Angeles, Automerge - "after 5pm,every weekend" in timezone America/Los_Angeles. 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR was generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View the [repository job log](https://developer.mend.io/github/valora-inc/wallet). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy40MjEuMCIsInVwZGF0ZWRJblZlciI6IjM3LjQzOC4wIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJucG0iLCJyZW5vdmF0ZSJdfQ==--> --------- Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Satish Ravi <[email protected]>
](https://renovatebot.com){kind=link}
|
This PR has actually introduced a bug #2074 into the library. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2054
UIGraphicsBeginImageContext()is deprecated in iOS 17 and when the width or height is 0, it throws an exception.The solution is to replace it with
UIGraphicsImageRenderer.See blog post.