-
Notifications
You must be signed in to change notification settings - Fork 5.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Frontend Failing Test: paddle - comparison.numpy.less_equal #28688
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR Compliance Checks
Thank you for your Pull Request! We have run several checks on this pull request in order to make sure it's suitable for merging into this project. The results are listed in the following section.
Issue Reference
In order to be considered for merging, the pull request description must refer to a specific issue number. This is described in our contributing guide and our PR template.
This check is looking for a phrase similar to: "Fixes #XYZ" or "Resolves #XYZ" where XYZ is the issue number that this PR is meant to address.
Conventional Commit PR Title
In order to be considered for merging, the pull request title must match the specification in conventional commits. You can edit the title in order for this check to pass.
Most often, our PR titles are something like one of these:
- docs: correct typo in README
- feat: implement dark mode"
- fix: correct remove button behavior
Linting Errors
- Found type "null", must be one of "feat","fix","docs","style","refactor","perf","test","build","ci","chore","revert"
- No subject found
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @ZJay07
Thanks for the PR
The implementation here should be able to handle more than just ones specified as supported. For example int8 works but is not included in the supoorted types
you can check by
ivy.set_paddle_backend()
x = ivy.array(2, dtype="int8")
print(ivy.less_equal(x,x))
In addition, the function also seems to be explicitly handling complex types.
Hi @Ishticode, thanks for the review, should the function be allowed to handle |
Yes. Does it get the same results as jax? |
Hey @Ishticode managed to fix it seems like it was missing some equal signs since it is comparing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That looks right but the int8 dtype is still not speciifed as supported. As you can see it does work with native paddle in the example given above. Could you include that? Thanks :)
any updates @ZJay07 on this one? :) |
Hey @Ishticode, currently busy with exams but will be back to fixing it later this month! |
PR Description
https://www.paddlepaddle.org.cn/documentation/docs/en/2.2/api/paddle/less_equal_en.html#less-equal
Specify dtypes based on
paddlepaddle
docsRelated Issue
Close #28687
Checklist
Socials