Skip to content

fix(core-ingestion): preserve effective container in chunks#169

Open
changhoon-sung wants to merge 1 commit intoix-infrastructure:devfrom
changhoon-sung:worktree-fix-effective-container-pr
Open

fix(core-ingestion): preserve effective container in chunks#169
changhoon-sung wants to merge 1 commit intoix-infrastructure:devfrom
changhoon-sung:worktree-fix-effective-container-pr

Conversation

@changhoon-sung
Copy link
Copy Markdown
Contributor

Summary

  • keep method chunks aligned with effectiveContainer instead of the weaker enclosing fallback
  • add a Go parser regression test that asserts both the entity and chunk retain the receiver-owned container
  • preserve the previously fixed method ownership behavior in the parser output

Test plan

  • npm --prefix core-ingestion test -- --run src/__tests__/queries.go.test.ts
  • broader parser test suite if desired

Keep method chunks aligned with entity ownership so Go receiver methods and similar cases retain the computed effective container.
Copilot AI review requested due to automatic review settings April 8, 2026 19:48
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes a Go parsing edge case where method chunks were assigned the weaker “enclosing” container instead of the receiver-owned effectiveContainer, ensuring chunk symbol keys stay aligned with method entity ownership.

Changes:

  • Set pendingChunks[].container to effectiveContainer (receiver/interface-owned) rather than enclosing.
  • Add a Go regression test asserting both the method entity and method chunk retain container: 'Service'.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
core-ingestion/src/index.ts Aligns chunk container attribution with effectiveContainer to preserve method ownership in chunk output.
core-ingestion/src/__tests__/queries.go.test.ts Adds regression assertions that both entities and chunks preserve the receiver-owned container for Go methods.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants