fix(core-ingestion): preserve effective container in chunks#169
Open
changhoon-sung wants to merge 1 commit intoix-infrastructure:devfrom
Open
fix(core-ingestion): preserve effective container in chunks#169changhoon-sung wants to merge 1 commit intoix-infrastructure:devfrom
changhoon-sung wants to merge 1 commit intoix-infrastructure:devfrom
Conversation
Keep method chunks aligned with entity ownership so Go receiver methods and similar cases retain the computed effective container.
There was a problem hiding this comment.
Pull request overview
This PR fixes a Go parsing edge case where method chunks were assigned the weaker “enclosing” container instead of the receiver-owned effectiveContainer, ensuring chunk symbol keys stay aligned with method entity ownership.
Changes:
- Set
pendingChunks[].containertoeffectiveContainer(receiver/interface-owned) rather thanenclosing. - Add a Go regression test asserting both the method entity and method chunk retain
container: 'Service'.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
core-ingestion/src/index.ts |
Aligns chunk container attribution with effectiveContainer to preserve method ownership in chunk output. |
core-ingestion/src/__tests__/queries.go.test.ts |
Adds regression assertions that both entities and chunks preserve the receiver-owned container for Go methods. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
effectiveContainerinstead of the weaker enclosing fallbackTest plan
npm --prefix core-ingestion test -- --run src/__tests__/queries.go.test.ts