Fix/node version guard and fetch error unwrap#187
Closed
Conversation
…causes Users on Node 18 hit a bare "fetch failed" during ix map with no hint at the underlying cause. Root causes: (1) no engines field or runtime check, so install and startup succeed silently on EOL Node, and (2) ix map's error handler printed err.message, discarding the real transport error that undici stashes in err.cause. - Add engines.node >=20 to ix-cli/package.json - Add runtime Node major-version guard in ix-cli/src/cli/main.ts that exits early with an actionable message on Node <20 - Add formatFetchError in ix-cli/src/cli/errors.ts that unwraps err.cause for fetch TypeErrors, exposing codes like ECONNRESET / UND_ERR_SOCKET - Use formatFetchError at both error sites in ix-cli/src/cli/commands/map.ts - Document Node 20+ in README Requirements section
Node 18's bundled undici 5.x has a 300s headersTimeout default that silently kills long-running fetch calls like /v1/map, causing the reported "fetch failed" with no actionable detail. Node 20's undici 6.x fixed this. Node 18 is also EOL as of April 2025. The runtime guard in main.ts already enforces >=20, but the install scripts, build script, setup script, and requirements.txt still allowed 18 — meaning users could install successfully on Node 18 only to hit a cryptic failure at runtime. Updated: - scripts/install/install.sh (NODE_MIN_MAJOR) - scripts/install/install.ps1 ($NodeMinMajor) - scripts/build-cli.sh (version check + error message) - scripts/dev/setup.sh (hint text) - requirements.txt (node>=20, comment)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
What does this PR change?
Type
Changes
Validation
How did you test this?
Checklist