Skip to content

Fix error reporting spam from Pro features and duplicates #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
TannerTorrey3 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix error reporting spam from Pro features and duplicates #3

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 23 additions & 0 deletions hooks/ix-errors.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -151,6 +151,15 @@ _ixe_github_report() {
local stderr_block=""
[ -n "$6" ] && stderr_block=$(printf '\n### Stderr\n\n```\n%s\n```' "$6")

# Search GitHub for an existing open issue with the same fingerprint
if [ -z "$existing" ] || [ "$existing" = "null" ]; then
existing=$(gh issue list --repo "$IX_ERROR_REPO" --label "auto-reported" \
--state open --search "fp:${7} in:body" --json number --jq '.[0].number // empty' \
2>/dev/null || echo "")
# Update local rate-limit store if we found one on GitHub
[ -n "$existing" ] && _ixe_rate_update "$7" "$existing"
fi

if [ -n "$existing" ] && [ "$existing" != "null" ]; then
local comment
comment=$(printf '**Recurrence** — %s\n\n- Exit: `%s`\n- Action: `%s`%s' \
Expand Down Expand Up @@ -198,6 +207,17 @@ BODY
_ixe_rate_update "$7" "$issue_num"
}

# ── Pro feature detection ─────────────────────────────────────────────────────
# Returns 0 if the message/stderr indicates a missing Pro feature (not an error).
_ixe_is_pro_feature_msg() {
local combined="$1 $2"
case "$combined" in
*"requires Ix Pro"*|*"Install @ix/pro"*|*"is a Ix/pro feature"*|*"premium features"*)
return 0 ;;
esac
return 1
}

# ── Public: capture and report asynchronously (fire-and-forget) ───────────────
# Usage: ix_capture_async <type> <component> <message> <exit_code> [cmd_summary] [stderr]
# type: plugin | ix | integration | unknown
Expand All @@ -208,6 +228,9 @@ ix_capture_async() {
local _type="$1" _comp="$2" _msg="${3:-unknown error}" \
_ec="${4:-1}" _cmd="${5:-}" _stderr="${6:-}"

# Skip expected Pro feature messages — these are not errors
_ixe_is_pro_feature_msg "$_msg" "$_stderr" && return 0

(
set +e # Never let errors abort the background reporter

Expand Down
16 changes: 16 additions & 0 deletions hooks/ix-report.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,6 +55,22 @@ for f in "$UNSENT_DIR"/*.json; do
[ -z "$fp" ] && { rm -f "$f"; continue; }
[ -z "$title" ] && { FAILED=$(( FAILED + 1 )); continue; }

# Check if an issue with this fingerprint already exists on GitHub
existing=$(gh issue list --repo "$IX_ERROR_REPO" --label "auto-reported" \
--state open --search "fp:${fp} in:body" --json number --jq '.[0].number // empty' \
2>/dev/null || echo "")

if [ -n "$existing" ]; then
# Issue already exists — add a recurrence comment instead of creating a duplicate
gh issue comment "$existing" --repo "$IX_ERROR_REPO" \
--body "**Recurrence** (retry) — $(date -u +%Y-%m-%dT%H:%M:%SZ 2>/dev/null)" \
>/dev/null 2>&1
_ixe_rate_update "$fp" "$existing"
rm -f "$f"
PROCESSED=$(( PROCESSED + 1 ))
continue
fi

url=$(gh issue create \
--repo "$IX_ERROR_REPO" \
--title "$title" \
Expand Down