Send all reminders on set_reminders, even disabled ones #17
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Correction of typos
set_enabled_reminders implements the old behaviour if needed ...
Owner
|
Ok, I'll take a look at this soon. I've been quite busy with new version of
the app and an auto-translate library.
…On Sat, Dec 14, 2024, 2:33 PM fdlamotte ***@***.***> wrote:
Current implementation removes disabled reminders before sending them. It
might not be what the user want because it is then not possible to disable
them.
set_enabled_reminders implements the old behaviour if the function is
needed ...
I could have implemented a send_all_reminders and keep the behaviour of
send_reminders, but it seemed more logical to me this way (I would
personally remove set_enabled_reminders but don't know if it is usefull to
anyone).
------------------------------
You can view, comment on, or merge this pull request online at:
#17
Commit Summary
- db92ddf
<db92ddf>
Send all reminders on set_reminders, even disabled ones
File Changes
(1 file <https://github.com/izivkov/GShockTimeServer/pull/17/files>)
- *M* src/gshocktimeserver/gshock_api.py
<https://github.com/izivkov/GShockTimeServer/pull/17/files#diff-0ee52fcb62b08de505e256c9a2cbe42148dc2e35974c09a8e95118d43d56ae32>
(26)
Patch Links:
- https://github.com/izivkov/GShockTimeServer/pull/17.patch
- https://github.com/izivkov/GShockTimeServer/pull/17.diff
—
Reply to this email directly, view it on GitHub
<#17>, or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AA7M37QEE7VFRX5AEVYENM32FSBYZAVCNFSM6AAAAABTTZS4JSVHI2DSMVQWIX3LMV43ASLTON2WKOZSG42DAMJRGI3DQMY>
.
You are receiving this because you are subscribed to this thread.Message
ID: ***@***.***>
|
Contributor
Author
|
No hurry. It just happens I had some time yesterday ... but it might not happen again soon with the festivities coming ;) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current implementation removes disabled reminders before sending them. It might not be what the user want because it is then not possible to disable them.
set_enabled_reminders implements the old behaviour if the function is needed ...
I could have implemented a send_all_reminders and keep the behaviour of send_reminders, but it seemed more logical to me this way (I would personally remove set_enabled_reminders but don't know if it is usefull to anyone).