Add support for non-latin slugs & relevant tests as well #11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sentinel-1
commented
Aug 15, 2024
sentinel-1
commented
- Added support for Unicode slugs by changing regular expressions.
- Added test case based on Georgian language to test the new feature (e.g. Unicode slugs)
Enabling Unicode slugs is a major change in the behavior of the library. Therefore, updating the major version of the library from 2.0.0 to 3.0.0.
|
Related as well to the issue #10 |
|
As confirmed by the newly added tests this pull request also solves #10 |
sentinel-1
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.