Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add conditional loading of vfio_virqfd kernel module #73

Merged
merged 2 commits into from
Mar 8, 2024

Conversation

glanch
Copy link
Contributor

@glanch glanch commented Mar 1, 2024

Since Linux kernel version 6.2 vfio_virqfd was merged into vfio kernel module [1]. This PR loads the vfio_virqfd kernel module only if the kernel version is older than 6.2. This enables the usage of the vfio module of this flake with kernel versions >= 6.2.

Please let me know if there is a better way to create a conditional entry in a list.

[1] https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=e2d55709398e62cf53e5c7df3758ae52cc62d63a

modules/vfio/default.nix Outdated Show resolved Hide resolved
@j-brn
Copy link
Owner

j-brn commented Mar 8, 2024

Thanks for the contribution! I added a suggestion about the conditional list entry, but other than that it looks good to me.

@j-brn j-brn merged commit 997afdd into j-brn:master Mar 8, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants