Update README.md #144
Open
Update README.md #144
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added image for clarification about Custom Filter. Currently, it expects value that is not clear. Additionally, adds new explanation and examples for `Filter Function`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added an image to clarify the Custom Filter. Currently, it expects a value that is not clear.
Also, added new explanation and examples for
Filter FunctionSuggestion related to these changes:
I spent a good time figuring out what value I should pass into Custom Filter, the main reason is the hint is giving the wrong idea (I also saw a couple of people struggle with the same thing, some of them are in the issues) and if you aren't native in the js world (most of us are) then this is quite confusing. It looks like it is expecting us to provide
dv.pages('somefilterhere')whereas it is only expectingsomefilterhereIf the hint is updated to indicate what is the example value is, then this should be just solved.