fix: atomic Worktree.Checkout — prevent inconsistent state on sparse checkout failure - #4
Open
johneapen80 wants to merge 1 commit into
Open
Conversation
…e checkout failure Order of operations: Reset first (with internal setHEAD) → only update HEAD on success → restore original HEAD on failure
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes inconsistent repository state during Worktree.Checkout() sparse checkout operations.
Root cause: In Checkout(), setHEADToCommit was called BEFORE Reset(). If Reset failed mid-operation, HEAD already pointed to the target commit while working tree and index were not updated — leaving repository in inconsistent state.
Fix: Atomic checkout — Reset first (which handles setHEAD internally), only update HEAD on success, and restore original HEAD on failure.
Closes #1