feat: Persistent disk, Docker details post, EnvVars in ServicePOST and Image in ServicePOST #6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tazarov
commented
Sep 23, 2023
tazarov
commented
- Added support for persistent disk in the WebServiceDetails as it is supported by Render API
- Added an example service with disk support in README.md
- Fixed a typo in the flask example's env type
- Fixed an issue with deleting ServiceEnvironmentResource where API returns 200 but code expects 201 - Added conditional populate of disk struct - Added `disk` to schema
Author
|
@jackall3n, I tested the changes locally, and everything seems to be working. |
- Added support for EnvVar in ServicePOST request - Added support for Image type of service in ServicePOST
tazarov
changed the title
Author
|
@jackall3n before this can be merged, you need to merge - jackall3n/render-go#4 |
Owner
merged |
jackall3n
reviewed
Mar 4, 2024
|
|
||
| if err != nil { | ||
| resp.Diagnostics.AddError("failed to update service variables", err.Error()) | ||
| resp.Diagnostics.AddError("failed to update service variables1", err.Error()) |
Owner
There was a problem hiding this comment.
Suggested change
| resp.Diagnostics.AddError("failed to update service variables1", err.Error()) | |
| resp.Diagnostics.AddError("failed to update service variables", err.Error()) |
There was a problem hiding this comment.
Hi! Is this the only blocking point for this PR?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.