-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FIXES] Fix deprecated sass, Polish translation, types, build command #1929
base: master
Are you sure you want to change the base?
Conversation
…ved from grunt-sass to grunt-contrib-sass
… exports /utils, but types export /utils-compiled)
Hi @jackocnr, I see that you released new version since this request was created but you haven't included it in release. |
Hi there, thanks for putting this together. Unfortunately, I have very limited time to commit to open-source over the next month or so, so all I can do is merge very simple straightforward PRs e.g. basically just simple translations and LPN updates. I see you're including a translation change here, but the logic looks complicated so I'm afraid I won't be able to review this for a while. One thing I can say is that you have included a lot of different changes in this PR, and when I have time to review it, probably in late March to be honest, I will need more information on why each change needs to happen, and why your approach fixes the issue e.g. for the Polish language change, can you describe what the current problem is, with an example, and provide a source to justify your approach here. Thanks. And apologies for the delay, but life gets in the way of open-source sometimes! |
@jackocnr np. I just wanted to know when merge can be expected. Also here's why this changes need to happen:
|
npm run build
types generationutils-compiled
not asutils
)