Remove ipv6 support and add logging #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ed by protocol" and add logging support to services
|
Thanks for your PR and sorry for late response because i don't have too much time on this project. It's pretty weird that i have not encounter the ipv6 "Address family not supported by protocol" issue of nginx under docker . I'll remove ipv6 listen later. In my mind, those services without logging is a kind of infra so i decide not to log it. Anyway since this is just a template project, you can modify anything as you like. Besides |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove ipv6 support that causes the error "Address family not supported by protocol" and add logging support to services