Improve the email template (plain-text edition) #321
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change email subject to: New comment on “Thread Name” Out-of-date translations get “New Comment” (should still work) instead of “New Comment – <domain>”. The domain was moved to the From field in jacobwb#316.
* Greet the email recipient. * Better explain what’s going on. * Including a call-to-action. * Use an RFC 3676 signature separator line (hyphen-hyphen-space).
|
+1 please merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When testing Hashover, my inbox quickly got filled with emails I couldn’t tell apart. They weren’t catching my attention and I felt I didn’t know what to do about them.
I’ve changed the email subject to include the thread title instead of the domain name. This makes it easier to recognize why you’re receiving the email and what’s it about. It also makes it more interesting as it’s a topic you’ve already shown interest in. I’ve also added some new strings and reworked the plain-text email template. The email now greets you, better explains what do do, and includes a call-to-action.
The name and title is quoted for security (there are few options in plain-text to distinguish between user-submitted content and the template).