-
Notifications
You must be signed in to change notification settings - Fork 161
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bug]: fix spelling issues #701
Comments
## Which problem is this PR solving? - Resolves #701 ## Checklist - [x] I have read https://github.com/jaegertracing/jaeger/blob/master/CONTRIBUTING_GUIDELINES.md - [x] I have signed all commits --------- Signed-off-by: Jeeva Ramanathan <[email protected]> Signed-off-by: Yuri Shkuro <[email protected]> Co-authored-by: Yuri Shkuro <[email protected]>
## Which problem is this PR solving? - Part of #701 ## Checklist - [x] I have read https://github.com/jaegertracing/jaeger/blob/master/CONTRIBUTING_GUIDELINES.md - [x] I have signed all commits Signed-off-by: JeevaRamanathan <[email protected]>
## Which problem is this PR solving? - part of #701 ## Description of the changes - fixed typo behaviour , ingestor ## How was this change tested? - make spellcheck ## Checklist - [ ] I have read https://github.com/jaegertracing/jaeger/blob/master/CONTRIBUTING_GUIDELINES.md - [ ] I have signed all commits - [ ] I have added unit tests for the new functionality - [ ] I have run lint and test steps successfully - for `jaeger`: `make lint test` - for `jaeger-ui`: `yarn lint` and `yarn test` --------- Signed-off-by: danish siddiqui <[email protected]>
Solving issue:- [fix spelling issues #701] Grammatical errors have been corrected in the docs next-release/*.md replaces closed PR #716 --------- Signed-off-by: Anmol Singh <[email protected]> Signed-off-by: Yuri Shkuro <[email protected]> Co-authored-by: Yuri Shkuro <[email protected]>
does this issue is still present ? or has been solved. |
the two words "telemtery","trft" are still on the file , does the words needs to be removed? |
@priyanshsao yes they should be removed from the dictionaries |
when i searched for the word "trft" i got these- content/docs/1.16/operator.md:979: name: jg-compact-trft |
does the word "trft" needs to be replaced with some other word or we just need to remove those two words from the dictionary. |
I think in those cases it can be replaced with |
@yurishkuro, I just discovered that the word 'promethesus' is also present in the same file, which wasn't mentioned in this issue. It appears to be misspelled and isn't used anywhere in the content folder . Should this be considered a typo that needs to be removed as well? |
Yes |
We spellcheck the content using
make spellcheck
, which uses a dictionary of wordsscripts/cspell/project-words.txt
. However, this dictionary was seeded with some clearly misspelled words, at minimum those shown in the diff below. The goal is to fix the occurrences of those misspelled words in the main content (e.g. by finding them withgrep -rn {word} content/
) and remove them from the dictionary file.The text was updated successfully, but these errors were encountered: