-
Notifications
You must be signed in to change notification settings - Fork 161
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix typo in OpenTelemetry #700
Conversation
Signed-off-by: Marcin Ziółkowski <[email protected]>
Signed-off-by: MA3CIN <[email protected]>
✅ Deploy Preview for romantic-neumann-1959d7 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I recall there were many misspelled words added to the dictionary file, can you check?
@yurishkuro Yes, you are right. Some of these are an easy fix, but the rest... I'm not sure if these are even words in English...? |
boths sounds like a typo, the others are people's names (interns from the mentorship program / page). I don't know what a good way to handle this, we cannot just remove them from the dictionary, the linter will start failing. |
@yurishkuro Alright, then i propose the following: |
Sure, but to complete this PR I want to make sure this misspelled work is not in the dictionary. |
@yurishkuro I see - all three (opentelemetry, opentracing, openzipkin) are spelled correctly in the dictionary. I checked that initially, but didn't comment that I did. The spellechecker must have ignored Markdown hashtags, and interpreted them as a comment. |
Which problem is this PR solving?
a typo in troubleshooting.MD
Surprisingly, the spellcheck didn't pick this one up, probably due to the Markdown hashtags being interpreted as a comment.
Checklist
jaeger
:make lint test
jaeger-ui
:yarn lint
andyarn test