add more test

Signed-off-by: zzzk1 <[email protected]>

internal/storage/v2/clickhouse/factory_test.go

@@ -7,6 +7,7 @@ import (
 	"testing"
 
 	"github.com/ClickHouse/ch-go/cht"
+	"github.com/stretchr/testify/assert"
 	"github.com/stretchr/testify/require"
 	"go.uber.org/zap"
 
@@ -27,8 +28,9 @@ func TestClickHouseFactoryWithConfig(t *testing.T) {
 	cht.New(t,
 		cht.WithLog(zap.NewNop()),
 	)
-	_, err := NewFactoryWithConfig(&cfg, zap.NewNop())
+	f, err := NewFactoryWithConfig(&cfg, zap.NewNop())
 	require.NoError(t, err)
+	defer f.Close()
 }
 
 func TestCreateTraceWriter(t *testing.T) {
@@ -40,6 +42,8 @@ func TestCreateTraceWriter(t *testing.T) {
 
 	f, err := NewFactoryWithConfig(&cfg, zap.NewNop())
 	require.NoError(t, err)
-	_, err = f.CreateTraceWriter()
+	traceWriter, err := f.CreateTraceWriter()
 	require.NoError(t, err)
+	assert.NotEmpty(t, traceWriter)
+	defer f.Close()
 }

pkg/clickhouse/config/config.go

@@ -97,6 +97,9 @@ func (c *Configuration) newPool(log *zap.Logger) (*chpool.Pool, error) {
 		HealthCheckPeriod: c.ConnectionPoolConfig.HealthCheckPeriod,
 	}
 	chPool, err := chpool.Dial(context.Background(), option)
+	if err != nil {
+		return nil, err
+	}
 	return chPool, err
 }
 
@@ -112,5 +115,8 @@ func (c *Configuration) newConn() (driver.Conn, error) {
 		},
 	}
 	conn, err := clientV2.Open(&option)
+	if err != nil {
+		return nil, err
+	}
 	return conn, err
 }

pkg/clickhouse/config/config_test.go

@@ -10,8 +10,6 @@ import (
 	"github.com/stretchr/testify/assert"
 	"github.com/stretchr/testify/require"
 	"go.uber.org/zap"
-
-	"github.com/jaegertracing/jaeger/pkg/testutils"
 )
 
 func TestDefaultConfig(t *testing.T) {
@@ -35,6 +33,41 @@ func TestNewClientWithDefaults(t *testing.T) {
 	defer client.Close()
 }
 
-func TestMain(m *testing.M) {
-	testutils.VerifyGoLeaks(m)
+func TestNewPool(t *testing.T) {
+	cfg := DefaultConfiguration()
+	logger := zap.NewNop()
+	conn, err := cfg.newConn()
+
+	cht.New(t,
+		cht.WithLog(logger),
+	)
+
+	require.NoError(t, err)
+	assert.NotEmpty(t, conn)
+	defer conn.Close()
+}
+
+func TestNewPoolFail(t *testing.T) {
+	cfg := Configuration{}
+	logger := zap.NewNop()
+	pool, err := cfg.newPool(logger)
+
+	cht.New(t,
+		cht.WithLog(logger),
+	)
+
+	require.Error(t, err)
+	assert.Nil(t, pool)
+}
+
+func TestNewConnection(t *testing.T) {
+	cfg := DefaultConfiguration()
+	logger := zap.NewNop()
+
+	cht.New(t, cht.WithLog(logger))
+
+	conn, err := cfg.newConn()
+	require.NoError(t, err)
+	assert.NotEmpty(t, conn)
+	defer conn.Close()
 }