Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix /qualitymetrics to return data in expected format #6733

Merged
merged 3 commits into from
Feb 15, 2025

Conversation

yurishkuro
Copy link
Member

@yurishkuro yurishkuro commented Feb 15, 2025

Which problem is this PR solving?

Description of the changes

  • Remove intermediate data: element from the response
  • Match response to what the UI expects
  • Fix unit test that wasn't testing the output

How was this change tested?

Copy link

codecov bot commented Feb 15, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.02%. Comparing base (23d2254) to head (e5f3b45).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6733      +/-   ##
==========================================
- Coverage   96.06%   96.02%   -0.04%     
==========================================
  Files         364      364              
  Lines       20696    20692       -4     
==========================================
- Hits        19881    19869      -12     
- Misses        622      628       +6     
- Partials      193      195       +2     
Flag Coverage Δ
badger_v1 9.76% <ø> (ø)
badger_v2 1.82% <ø> (ø)
cassandra-4.x-v1-manual 14.81% <ø> (ø)
cassandra-4.x-v2-auto 1.81% <ø> (ø)
cassandra-4.x-v2-manual 1.81% <ø> (ø)
cassandra-5.x-v1-manual 14.81% <ø> (ø)
cassandra-5.x-v2-auto 1.81% <ø> (ø)
cassandra-5.x-v2-manual 1.81% <ø> (ø)
elasticsearch-6.x-v1 19.15% <ø> (ø)
elasticsearch-7.x-v1 19.23% <ø> (ø)
elasticsearch-8.x-v1 19.40% <ø> (ø)
elasticsearch-8.x-v2 1.82% <ø> (ø)
grpc_v1 10.81% <ø> (ø)
grpc_v2 7.80% <ø> (ø)
kafka-3.x-v1 10.13% <ø> (ø)
kafka-3.x-v2 1.82% <ø> (ø)
memory_v2 1.82% <ø> (ø)
opensearch-1.x-v1 19.28% <ø> (ø)
opensearch-2.x-v1 19.28% <ø> (ø)
opensearch-2.x-v2 1.82% <ø> (ø)
tailsampling-processor 0.48% <ø> (ø)
unittests 94.91% <100.00%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Yuri Shkuro <[email protected]>
@yurishkuro yurishkuro marked this pull request as ready for review February 15, 2025 13:42
@yurishkuro yurishkuro requested a review from a team as a code owner February 15, 2025 13:42
Signed-off-by: Yuri Shkuro <[email protected]>
@yurishkuro yurishkuro enabled auto-merge February 15, 2025 13:57
Copy link
Contributor

@jkowall jkowall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks.

@yurishkuro yurishkuro added this pull request to the merge queue Feb 15, 2025
Merged via the queue into jaegertracing:main with commit c78f5c3 Feb 15, 2025
55 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create dummy /quality-metrics endpoint
2 participants