Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[remote-storage][v2] Add proto definition for GetServices and GetOperations rpc #6736

Merged
merged 6 commits into from
Feb 16, 2025

Conversation

mahadzaryab1
Copy link
Collaborator

@mahadzaryab1 mahadzaryab1 commented Feb 15, 2025

Which problem is this PR solving?

Description of the changes

  • This PR creates a protobuf definition in traces_storage.proto for the GetServices and GetOperations RPCs.

How was this change tested?

  • CI

Checklist

Copy link

codecov bot commented Feb 15, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.04%. Comparing base (f956a13) to head (19aba57).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6736      +/-   ##
==========================================
- Coverage   96.06%   96.04%   -0.02%     
==========================================
  Files         364      364              
  Lines       20692    20692              
==========================================
- Hits        19877    19874       -3     
- Misses        622      624       +2     
- Partials      193      194       +1     
Flag Coverage Δ
badger_v1 9.76% <ø> (ø)
badger_v2 1.82% <ø> (ø)
cassandra-4.x-v1-manual 14.81% <ø> (ø)
cassandra-4.x-v2-auto 1.81% <ø> (ø)
cassandra-4.x-v2-manual 1.81% <ø> (ø)
cassandra-5.x-v1-manual 14.81% <ø> (ø)
cassandra-5.x-v2-auto 1.81% <ø> (ø)
cassandra-5.x-v2-manual 1.81% <ø> (ø)
elasticsearch-6.x-v1 19.15% <ø> (ø)
elasticsearch-7.x-v1 19.23% <ø> (ø)
elasticsearch-8.x-v1 19.40% <ø> (ø)
elasticsearch-8.x-v2 1.82% <ø> (ø)
grpc_v1 10.81% <ø> (ø)
grpc_v2 7.80% <ø> (ø)
kafka-3.x-v1 10.13% <ø> (ø)
kafka-3.x-v2 1.82% <ø> (ø)
memory_v2 1.82% <ø> (ø)
opensearch-1.x-v1 19.28% <ø> (ø)
opensearch-2.x-v1 19.28% <ø> (ø)
opensearch-2.x-v2 1.82% <ø> (ø)
tailsampling-processor 0.48% <ø> (ø)
unittests 94.93% <ø> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yurishkuro yurishkuro added this pull request to the merge queue Feb 16, 2025
Merged via the queue into jaegertracing:main with commit 316cbe3 Feb 16, 2025
55 checks passed
@mahadzaryab1 mahadzaryab1 deleted the proto-definitions-2 branch February 16, 2025 03:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants