[remote-storage][v2] Add complete IDL for trace storage #6737
+416
−35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mahad Zaryab <[email protected]>
mahadzaryab1
commented
Feb 16, 2025
mahadzaryab1
commented
Feb 16, 2025
| // The chunking rules are the same as for GetTraces. | ||
| // | ||
| // If no matching traces are found, an empty stream is returned. | ||
| // If an error is encountered, the iterator returns the error and stops. |
There was a problem hiding this comment.
@yurishkuro How should we handle error cases?
mahadzaryab1
commented
Feb 16, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6737 +/- ##
=======================================
Coverage 96.04% 96.04%
=======================================
Files 364 364
Lines 20692 20692
=======================================
Hits 19874 19874
Misses 624 624
Partials 194 194
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
yurishkuro
reviewed
Feb 16, 2025
Signed-off-by: Mahad Zaryab <[email protected]>
mahadzaryab1
commented
Feb 16, 2025
mahadzaryab1
commented
Feb 16, 2025
mahadzaryab1
commented
Feb 16, 2025
Signed-off-by: Mahad Zaryab <[email protected]>
Signed-off-by: Mahad Zaryab <[email protected]>
Signed-off-by: Mahad Zaryab <[email protected]>
Signed-off-by: Mahad Zaryab <[email protected]>
Signed-off-by: Mahad Zaryab <[email protected]>
Signed-off-by: Mahad Zaryab <[email protected]>
mahadzaryab1
commented
Feb 17, 2025
yurishkuro
reviewed
Feb 17, 2025
yurishkuro
reviewed
Feb 17, 2025
Comment on lines
134
to
136
| // There's currently an implementation-dependent ambiguity whether all query filters | ||
| // (such as multiple tags) must apply to the same span within a trace, or can be satisfied | ||
| // by different spans. |
There was a problem hiding this comment.
in the api_v3 it's actually stated unambiguously
Signed-off-by: Mahad Zaryab <[email protected]>
Signed-off-by: Mahad Zaryab <[email protected]>
Signed-off-by: Mahad Zaryab <[email protected]>
yurishkuro
reviewed
Feb 20, 2025
|
|
||
| // FindTraceIDsResponse represents the response for FindTracesRequest. | ||
| message FindTraceIDsResponse { | ||
| repeated bytes trace_ids = 1; |
There was a problem hiding this comment.
I just realized - shouldn't we be returning IDs with timestamps? We can do in a follow up PR, as it needs a change in storage API.
Signed-off-by: Mahad Zaryab <[email protected]>
yurishkuro
approved these changes
Feb 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
Description of the changes
trace_storage.protoby adding the remainingFindTracesandFindTraceIDsRPCs for theTraceReaderservice, along with theExportrpc for theTraceWriterservice.How was this change tested?
Checklist
jaeger:make lint testjaeger-ui:npm run lintandnpm run test