This repository has been archived by the owner on Sep 13, 2022. It is now read-only.
Throttler implementation #18
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
isaachier
changed the title
isaachier
force-pushed
the
throttler-implementation
branch
from
b6c96b9
to
0dd9d9d
Compare
vprithvi
reviewed
Jul 10, 2018
| @@ -2,4 +2,4 @@ distributionBase=GRADLE_USER_HOME | |||
| distributionPath=wrapper/dists | |||
| zipStoreBase=GRADLE_USER_HOME | |||
| zipStorePath=wrapper/dists | |||
| distributionUrl=https\://services.gradle.org/distributions/gradle-4.4-bin.zip | |||
| distributionUrl=https\://services.gradle.org/distributions/gradle-4.0-bin.zip | |||
There was a problem hiding this comment.
I messed this up. Good catch.
vprithvi
reviewed
Jul 10, 2018
| @@ -202,11 +202,20 @@ public synchronized Span setTag(String key, Number value) { | |||
| private Span setTagAsObject(String key, Object value) { | |||
| if (key.equals(Tags.SAMPLING_PRIORITY.getKey()) && (value instanceof Number)) { | |||
| int priority = ((Number) value).intValue(); | |||
| byte newFlags; | |||
|
|
|||
| // Ignore debug spans trying to re-enable debug. | |||
There was a problem hiding this comment.
Could you detail why in the comment?
isaachier
force-pushed
the
throttler-implementation
branch
from
7785619
to
3e28488
Compare
Codecov Report
@@ Coverage Diff @@
## master #18 +/- ##
============================================
- Coverage 84.73% 84.37% -0.36%
- Complexity 607 637 +30
============================================
Files 94 100 +6
Lines 2410 2516 +106
Branches 271 284 +13
============================================
+ Hits 2042 2123 +81
- Misses 276 292 +16
- Partials 92 101 +9
Continue to review full report at Codecov.
|
added 5 commits
August 9, 2018 13:14
Signed-off-by: Isaac Hier <[email protected]>
Signed-off-by: Isaac Hier <[email protected]>
Signed-off-by: Isaac Hier <[email protected]>
Signed-off-by: Isaac Hier <[email protected]>
Signed-off-by: Isaac Hier <[email protected]>
isaachier
force-pushed
the
throttler-implementation
branch
from
a020baa
to
765f05c
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Throttler implementation for Java.