Skip to content

fix(security): remove plaintext password storage from client authentication #87

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Akshu121796 wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix(security): remove plaintext password storage from client authentication #87

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
93ee721
fix(security): remove plaintext password storage from login flow
Akshu121796 Jul 28, 2026
8f4a638
Merge branch 'main' into fix/remove-localstorage-password
Akshu121796 Jul 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
54 changes: 44 additions & 10 deletions ...chain-main/organchain-main/TransplantChain-Organ_Donation_Application-main/src/login.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -463,16 +463,50 @@ <h3 class="text-lg font-extrabold text-slate-900 mb-1">Phase 2 Authentication</h
let identifier, password;
if (activeRole === 'patient') {
identifier = document.getElementById('patientIdentifier').value.trim();
password = document.getElementById('patientPassword').value.trim();
if (!identifier || !password) { showToast('Please fill in all fields.', 'error'); return; }

/* Demo: check against localStorage registered user */
const regEmail = localStorage.getItem('registeredEmail');
const regPwd = localStorage.getItem('registeredPassword');
if (regEmail && regPwd) {
if (identifier !== regEmail || password !== regPwd) {
showToast('Invalid credentials. Please try again.', 'error'); return;
}
password = document.getElementById('patientPassword').value.trim();

if (!identifier || !password) {
showToast('Invalid Credentials. Please try again.', 'error');
return;
}

const response = await fetch('/api/auth/login', {
method: 'POST',
headers: {
'Content-Type': 'application/json'
},
body: JSON.stringify({
email: identifier,
password
})
});
const data = await response.json();


if (!response.ok) {
showToast('Invalid credentials', 'error');
return;
}

const btn = form.querySelector('button[type="submit"]');
const btnText = btn?.querySelector('.btn-text');
const btnIcon = btn?.querySelector('.btn-icon');
const btnSpinner = btn?.querySelector('.btn-spinner');
const originalText = btnText ? btnText.textContent : 'Authenticate';

if (btn) {
if (btnText) btnText.textContent = 'Requesting Auth...';
if (btnIcon) btnIcon.classList.add('hidden');
if (btnSpinner) btnSpinner.classList.remove('hidden');
btn.disabled = true;
btn.classList.add('opacity-80', 'cursor-wait');
}

try {
const otp = await showOtpModal();
if (!otp) throw new Error('OTP Canceled');
if (otp !== '123456') throw new Error('Invalid OTP — use demo code: 123456');

sessionStorage.setItem('userRole', 'patient');
sessionStorage.setItem('abhaId', localStorage.getItem('patientABHA') || identifier);
sessionStorage.setItem('userName', localStorage.getItem('patientName') || identifier);
Expand Down
2 changes: 1 addition & 1 deletion ...in-main/organchain-main/TransplantChain-Organ_Donation_Application-main/src/register.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -367,7 +367,7 @@ <h4 class="text-sm font-extrabold text-slate-900 tracking-tight mb-1">Pledge Org
if (fname) localStorage.setItem('patientName', fname);
if (abha) localStorage.setItem('patientABHA', abha);
if (email) localStorage.setItem('registeredEmail', email);
if (pwd) localStorage.setItem('registeredPassword', pwd);


// Show green toast success event
showToast('Account Created!', 'Redirecting to Login...', true);
Expand Down
33 changes: 5 additions & 28 deletions Desktop/organchain-main/organchain-main/Version_1_Frontend/src/login.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -257,37 +257,14 @@ <h3 class="text-lg font-extrabold text-slate-900 mb-1">Phase 2 Authentication</h
}

// Hackathon Link intercept
const registeredEmail = localStorage.getItem('registeredEmail');
const registeredPassword = localStorage.getItem('registeredPassword');

// If the user registered recently via the UI demo, strictly check against those credentials
if (registeredEmail && registeredPassword) {
if (identifier !== registeredEmail || password !== registeredPassword) {
if (activeRole === 'patient') {
identifier = document.getElementById('patientIdentifier').value.trim();
password = document.getElementById('patientPassword').value.trim();

if (!identifier || !password) {
showToast('Invalid Credentials. Please try again.', 'error');
return;
}

// Match found! Fast track to dashboard
sessionStorage.setItem('userRole', 'patient');
sessionStorage.setItem('abhaId', localStorage.getItem('patientABHA') || identifier);
sessionStorage.setItem('userName', localStorage.getItem('patientName') || identifier);

const btn = form.querySelector('button[type="submit"]');
if (btn) {
const btnText = btn.querySelector('.btn-text');
const btnIcon = btn.querySelector('.btn-icon');
const btnSpinner = btn.querySelector('.btn-spinner');

if (btnText) btnText.textContent = 'Requesting Auth...';
if (btnIcon) btnIcon.classList.add('hidden');
if (btnSpinner) btnSpinner.classList.remove('hidden');
btn.disabled = true;
btn.classList.add('opacity-80', 'cursor-wait');
}

showToast('Authentication Successful! Redirecting...', 'success');
setTimeout(() => { window.location.href = 'dashboard.html'; }, 1500);
return;
}

} else {
Expand Down
2 changes: 1 addition & 1 deletion Desktop/organchain-main/organchain-main/Version_1_Frontend/src/register.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -357,7 +357,7 @@ <h4 class="text-sm font-extrabold text-slate-900 tracking-tight mb-1">Pledge Org
if (fname) localStorage.setItem('patientName', fname);
if (abha) localStorage.setItem('patientABHA', abha);
if (email) localStorage.setItem('registeredEmail', email);
if (pwd) localStorage.setItem('registeredPassword', pwd);


// Show green toast success event
showToast('Account Created!', 'Redirecting to Login...', true);
Expand Down