Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing vendor files #31

Closed
wants to merge 1 commit into from
Closed

Add missing vendor files #31

wants to merge 1 commit into from

Conversation

jaonoctus
Copy link

@jaonoctus jaonoctus commented Jan 6, 2018

not composer.json yet.

i'll do it latter, with a .gitignore (to ignore vendor/ dir)

#30

@CameronWills
Copy link

@jaimehgb. Aren't PRs like this a massive risk? These minified vendor JS files could have been modified to include malicious code? Given the recent hack of the Stellar web wallet BlackWallet.co
Can I suggest that any JS files or changes are only done by the repository owner.

@jaonoctus
Copy link
Author

@CameronWills I agree with you.

I just downloaded this missing files from the original site. You don't have to trust me, you can check diff in each one.

But yeah, it's recommendable to use a composer.json or package.json file instead (I don't have time to do yet. This PR is a workaround)

@jaonoctus jaonoctus closed this Sep 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants