Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[zh]translate learn/starter,supporter,projects,release/10 & update/translate menu #1950

Open
wants to merge 62 commits into
base: src
Choose a base branch
from

Conversation

laliwa
Copy link
Contributor

@laliwa laliwa commented Jul 4, 2024

translate learn/starter,supporter,projects,release/10
update/translate menu

ericpoirier and others added 30 commits January 30, 2023 15:36
adding Branding/Why Jakarta to Main Menu
translating why-jakarta-ee index page
update Chinese Community Supporting list
update why-jakarta-ee/table-of-contents with i18n config

Signed-off-by: laliwa <[email protected]>
2. edit the Chinese main menu to align with the english version
3. update Chinese Community pages adding Livestream China and Techtalk China new translated articles and new joiners
4. adding i18n setup to community/developer-advocate and Chinese config

Signed-off-by: laliwa <[email protected]>
Adds infographic 2023 and refactors infographic's i18n to use params.
ivargrimstad and others added 23 commits March 11, 2024 16:39
Adds up-to-date videos to the video page via build-time automation
Signed-off-by: Lukas Jungmann <[email protected]>
Co-authored-by: Ivar Grimstad <[email protected]>
Add blog post from Javaforum Malmö
update/translate menu

Signed-off-by: laliwa <[email protected]>
Copy link

netlify bot commented Jul 4, 2024

Deploy Preview for jakartaee ready!

Name Link
🔨 Latest commit e45f5a1
🔍 Latest deploy log https://app.netlify.com/sites/jakartaee/deploys/66c417a381669d0008fa3059
😎 Deploy Preview https://deploy-preview-1950--jakartaee.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@oliviergoulet5 oliviergoulet5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aside from some things mentioned below, this PR looks really good!

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to keep these index pages for /specifications.

Same for the ZH and JA locales.

Copy link
Contributor Author

@laliwa laliwa Jul 23, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for that checking, fix missing files now with this commit 0fa1968

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This shortcode has been replaced with layouts/shortcodes/guides_list.html. You shouldn't need to re-add the starter_guides.html shortcode.

This was to make the shortcode more generic to be used for other types of guides such as specification guides.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, got that, will notice that in the next commit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants