Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed issues regarding function prefixes and improved the documentation. #151

Merged
merged 4 commits into from
Feb 14, 2024

Conversation

Titanx-exe
Copy link

No description provided.

Copy link
Owner

@jakobbossek jakobbossek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Have you checked if devtools::check() returns any issues?

@Titanx-exe
Copy link
Author

Looks good to me. Have you checked if devtools::check() returns any issues?

I did not check. I can fork the repository again and fix it if it's not working.

@jakobbossek
Copy link
Owner

Well, there is no need for a new fork. Just run the check and also run the unit tests (should be devtools::test()) on your current fork. Should there be a problem: fix it and update the pull request.

@jakobbossek
Copy link
Owner

Looks good! Thanks @Titanx9-exe

@jakobbossek jakobbossek merged commit 4a10acb into jakobbossek:master Feb 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants