Upgrade to Bevy 0.14.0-rc.* & upgrade egui-gizmo dependency#107
Closed
zhaop wants to merge 14 commits intojakobhellermann:mainfrom
Closed
Upgrade to Bevy 0.14.0-rc.* & upgrade egui-gizmo dependency#107zhaop wants to merge 14 commits intojakobhellermann:mainfrom
zhaop wants to merge 14 commits intojakobhellermann:mainfrom
Conversation
but a bit buggy
accidentally committed changes
and added documentation here and there
to avoid panics
Addresses Bevy [9202](bevyengine/bevy#9202)
Addresses Bevy [13317](bevyengine/bevy#13317)
Addresses Bevy[9202](bevyengine/bevy#9202)
Addresses Bevy [12163](bevyengine/bevy#12163)
Addresses Bevy [12715](bevyengine/bevy#12715)
Contributor
Author
|
Or maybe this PR can be more self-contained and doesn't have to include the egui-gizmo change 🤔 |
|
bevy 14 is out now so you can probs update those git deps to be actual versioned deps |
Contributor
Author
|
Oops, just wanted to rename the branch to @alphastrata The Bevy dependency has been upgraded to the official version in #110, but looks like some of the dependencies still need to get their upgrades pushed to crates. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR allows bevy_editor_pls to be used with the newest Bevy 0.14 rc (currently at least rc.3), and is based on top of #106 by @ActuallyHappening .
Before anything happens to this, we should probably first:
transform_gizmo_bevyto updateeguiversion #106 merged & rebase this PR on topConcretely, this implements the following migration steps:
AppandSubAppinternals for better separation bevyengine/bevy#9202 : Use app.world_mut() or .world() instead of .worldAppandSubAppinternals for better separation bevyengine/bevy#9202 : Match app.get_sub_app as Option instead of ResultLegacyColortobevy_color::Colorbevyengine/bevy#12163 : Use Color::srgb* instead of Color::rgb*