Skip to content

Bug: Dropping leading plus sign #170

Open

Description

@avoylenko

The sbc-outbound drops the leading plus sign. As result, this behaviour does not allow us to use the numbers with leading + and the number sends out without the sign that forces the component on the other side to reject the call.

The fix is here #167

Activity

  1. davehorton commented on Mar 8, 2025

    @davehorton
    Collaborator

    plus sign presence is supposed to be dictated by carrier settings. Please provide a fuller description as to why this is not sufficent

  2. avoylenko commented on Mar 8, 2025

    @avoylenko
    ContributorAuthor

    @davehorton it's not about the carrier setting. Currently we have a hidden bug/feature where the sbc-outbound component removes the plus sign for all numbers that are coming to a carrier. In my scenario, i want to have some numbers with plus sign and other calls must be without as they are routing to the locally registered numbers on PBX.

  3. davehorton commented on Mar 8, 2025

    @davehorton
    Collaborator

    My point is more making sure this does not break existing functionaility for some customers

  4. avoylenko commented on Mar 10, 2025

    @avoylenko
    ContributorAuthor

    In that case, the PR might effect customer who does not know that the service drops the plus sign before sending the request further, but this could be easily fixed in application logic.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions