Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Re-work how play queue works #104

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Re-work how play queue works #104

wants to merge 3 commits into from

Conversation

jamesfiltness
Copy link
Owner

No description provided.

jamesfiltness
jamesfiltness commented Sep 3, 2017
View reviewed changes
app/actions/play-queue/index.js Outdated
dispatch(setIndex(currentIndex + 1));
dispatch(playTrack2(currentIndex + 1));
} else {
dispatch(setIndex(-1));
Copy link
Owner Author

@jamesfiltness jamesfiltness Sep 3, 2017 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use a middleware to manage player state such as index.

@jamesfiltness
Copy link
Owner Author

jamesfiltness commented Apr 21, 2018 •
edited
Loading

Play queue functionality is a good use case for a state machine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@jamesfiltness