Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MaxSize as a const fn #179

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

MaxSize as a const fn #179

wants to merge 4 commits into from
+494 −2

Conversation

jamesmunns
Copy link
Owner

No description provided.

@netlify Netlify
Copy link

netlify bot commented Oct 31, 2024 •
edited
Loading

✅ Deploy Preview for cute-starship-2d9c9b canceled.

Name Link
🔨 Latest commit 155b157
🔍 Latest deploy log https://app.netlify.com/sites/cute-starship-2d9c9b/deploys/672f80d16fec6d0008f781c5

@jamesmunns jamesmunns mentioned this pull request Nov 8, 2024
Open
jamesmunns
jamesmunns commented Nov 9, 2024
View reviewed changes
source/postcard-schema/src/max_size.rs Outdated
1
} else {
// CEIL(variants / 7)
(nvars.len() + 6) / 7
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This isn't right, it should be 2^7 not 7, we want to check how many variants fit in how many varint bytes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@jamesmunns