Skip to content
This repository has been archived by the owner on Nov 2, 2019. It is now read-only.

Checkbox #69

Closed
wants to merge 2 commits into from
Closed

Checkbox #69

wants to merge 2 commits into from

Conversation

jamesplease
Copy link
Owner

@jamesplease jamesplease commented Apr 15, 2018

Todo

Refactors

  • Emify
  • Update fill animation to use a circle
  • Confirm that CSS cannot get any lower specificity. There are quite a few > 1 specificity selectors in this thing

New Things

  • Add disabled state
    • Checked
    • Unchecked
  • Confirm that callback props like onX work as expected (I don't think that they do atm)
  • Focus state. Keyboard input works but there is no indicator when the checkbox is focused

Docs

  • Add docs to the website

This is a part of #64

@JPorry
Copy link
Collaborator

JPorry commented Apr 17, 2018

@JPorry
Copy link
Collaborator

JPorry commented Apr 17, 2018

I think that for the onX props we just need to spread the props in the input itself and we should be good

@JPorry JPorry closed this May 17, 2018
@jamesplease jamesplease deleted the checkbox branch May 17, 2018 18:13
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants