Tier 17.1: F3.2 sub-tier 1 — fact_option_executions columns (3 cols) - #19
Merged
Merged
Conversation
First sub-tier of WS2 F3.2 follow-on (the 92 missing-column rows remaining after the WS2 phantom-table burndown completed in Tier 16). Adds 3 spec-mapping columns to gold.fact_option_executions across all four dialects (Delta, Hive, Fabric Lakehouse, Fabric Warehouse): - trade_key_date TIMESTAMP CAT IM v4.1.0r15 sec 5.1.11 row 6 (MOOT) - fill_key_date TIMESTAMP CAT IM v4.1.0r15 sec 5.1.12.1 row 6 (MOOF/MOOFS) - prior_fill_key_date TIMESTAMP CAT IM v4.1.0r15 sec 5.1.12.3 row 9 (MOFA) All three are natural-key timestamps grouped with the existing trade_id, fulfillment_id, prior_fulfillment_id identifiers. Mapping CSV section-ref corrections (atomic with the DDL): - fill_key_date: sec 5.1.13.1 -> sec 5.1.12.1 - prior_fill_key_date: sec 5.1.14 -> sec 5.1.12.3 Both were PDF-verified via verify_cat_im_v3.py against the CAT IM v4.1.0r15 PDF. Allowlist: known_field_mapping_gaps.csv: 92 -> 89 rows (-3) F3.2 remaining: 89 (was 92) F3.1 phantom-table: 0 (unchanged, cleared in Tier 13-16) CHANGELOG: removed leftover stash-pop merge-conflict markers that were committed inadvertently with PR #18; both pre-conflict sections (Tier 15 banner + Tier 16 entry) preserved. All 8 guardrails pass.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
First sub-tier of WS2 F3.2 follow-on. Adds 3 spec-mapping columns to
fact_option_executionsacross all four dialects.Files changed
ddl/option/02_option_gold_delta.sql- add 3 columnsddl/option/04_option_gold_hive.sql- add 3 columnsddl/option/05_option_silver_fabric_lakehouse.sql- add 3 columnsddl/option/06_option_fabric_warehouse.sql- add 3 columnsddl/gold/06_cat_field_mapping.csv- 2 section-ref correctionsguardrails/known_field_mapping_gaps.csv- 92 → 89 rowsCHANGELOG.md- Tier 17.1 entry + cleanup of leftover merge-conflict markersColumns added
trade_key_datefill_key_dateprior_fill_key_dateMapping CSV corrections
PDF verification (via
verify_cat_im_v3.pyagainst the CAT IM v4.1.0r15 spec PDF) confirmed two pre-existing section-ref errors:fact_option_executions.fill_key_datefact_option_executions.prior_fill_key_dateCHANGELOG cleanup
PR #18 (Tier 16) merged with leftover stash-pop merge-conflict markers (
<<<<<<</=======/>>>>>>>) in CHANGELOG.md. This sub-tier removes them. Both pre-conflict sections (Tier 15 banner from PR #17 + Tier 16 entry from PR #18) are preserved as legitimate history.Coverage
F3.2 burndown progress
fact_option_executionsfact_option_allocationsfact_multileg_option_legsfact_option_order_eventsfact_multileg_option_eventsTest plan
fact_option_executionsmapping rows now resolve in DDL