Tier 17.3: F3.2 sub-tier 3 — fact_multileg_option_legs columns (5 cols) - #21
Merged
Merged
Conversation
Third sub-tier of WS2 F3.2 follow-on. Adds 3 new columns + renames 2 legacy columns on gold.fact_multileg_option_legs across all three dialects (Delta, Hive, Fabric Warehouse - multileg Gold has no Fabric Lakehouse variant). Added columns (CAT IM v4.1.0r15 section 5.2.1 row 32 legs sub-table): - leg_ref_id STRING/VARCHAR(64) row 32.n.1 legRefID - leg_symbol STRING/VARCHAR(14) row 32.n.2 symbol of stock leg - leg_option_id STRING/VARCHAR(22) row 32.n.3 optionID OSI symbol Renamed columns to canonical spec names: - leg_open_close -> leg_open_close_indicator (row 32.n.4 openCloseIndicator) - leg_ratio -> leg_ratio_quantity (row 32.n.6 legRatioQuantity) The view gold.vw_multileg_option_lifecycle (in the same files) was updated to reference the renamed columns and added the 3 new leg columns to its SELECT list. PDF spot-check confirmed all 6 leg fields (including the existing leg_side at row 32.n.5) on PDF page 289 in MLNO section 5.2.1. Allowlist: known_field_mapping_gaps.csv: 86 -> 81 rows (-5) F3.2 remaining: 81 (was 86) F3.1 phantom-table: 0 (unchanged, cleared in Tier 13-16) All 8 guardrails pass.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Third sub-tier of WS2 F3.2 follow-on. Adds 3 new columns + renames 2 legacy columns on
fact_multileg_option_legsacross all three multileg-Gold dialects (no Fabric Lakehouse variant for multileg).Files changed
ddl/multileg/02_multileg_gold_delta.sql- 3 cols added, 2 renamed, view updatedddl/multileg/04_multileg_fabric_warehouse.sql- same change pattern (T-SQL)ddl/multileg/06_multileg_gold_hive.sql- same change pattern (Hive)guardrails/known_field_mapping_gaps.csv- 86 → 81 rowsCHANGELOG.md- Tier 17.3 entryColumns added
leg_ref_idlegRefIDleg_symbolsymbol(within legs[])leg_option_idoptionIDColumns renamed
leg_open_closeleg_open_close_indicatoropenCloseIndicatorleg_ratioleg_ratio_quantitylegRatioQuantityRenames are atomic —
gold.vw_multileg_option_lifecycleview (in the same files) updated to use the new names. Silver-layer tables continue to use the original names; the Silver→Gold pipeline handles the rename.No mapping CSV fixes this sub-tier
PDF spot-check on page 289 confirmed all mapping CSV section refs (§5.2.1 row 32.n.X) are correct. The earlier verifier's
JSON_FIELD_NOT_IN_PDFandSECTION_MISMATCHflags were regex false negatives — the spec uses the multi-leg leg-indexed row format"32.n.N"that the verifier's^\\d+ <field>row-prefix regex doesn't catch.Coverage
F3.2 burndown progress
fact_option_executionsfact_option_allocationsfact_multileg_option_legsfact_option_order_eventsfact_multileg_option_eventsTest plan
fact_multileg_option_legsmapping rows now resolve in DDL