Tier 18.4: mapping CSV ROW_MISMATCH polish (post-audit followup #4 FINAL) - #27
Merged
Merged
Conversation
…NAL) Closes the last item on the post-audit followup list. With this merged, all four post-Tier-17.5 followups are complete and the cat-data-model is in a fully steady-state. Corrects 12 row-number references on fact_multileg_option_events rows in ddl/gold/06_cat_field_mapping.csv where the PDF-verified row number differs from the row originally claimed. All 12 corrections were identified during Tier 17.0's PDF verification pass and explicitly deferred to optional polish per Tier 17.5's CHANGELOG. Corrections in sec 5.2.2 (Multi-Leg Order Route Event): sender_imid: row 14 -> 13 destination: row 15 -> 14 destination_type: row 16 -> 15 routed_order_id: row 17 -> 16 session: row 18 -> 17 route_rejected_flag: row 27 -> 26 exch_origin_code: row 28 -> 27 paired_order_id: row 34 -> 28 Corrections in sec 5.2.6 (Multi-Leg Order Modified): prior_order_id: row 10 -> 9 initiator: row 22 -> 21 leaves_qty: row 27 -> 25 Corrections in sec 5.2.7 (Multi-Leg Order Cancelled): cancel_qty: row 13 -> 12 10 SECTION_MISMATCH cases identified in Tier 17.0 remain intentionally unmodified - they represent legitimate alternative references between multi-leg usage sites and single-leg canonical definition sites, both spec-supported. Verification: - All 8 guardrails pass. - 10/10 regression tests pass. - All 12 corrected rows match PDF spot-check exactly. POST-AUDIT STATE - STEADY: - F3.1 phantom backlog: 0 (closed Tier 13-16) - F3.2 missing-column backlog: 0 (closed Tier 17.1-17.5) - Post-audit tooling debt: 0 (closed Tier 18.1-18.4) - 4-dialect parity for option and multi-leg Gold layers - All 8 guardrails passing with 0 field-mapping allowlist exceptions
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Milestone
This PR closes the last item on the post-audit followup list. With this merged, all four post-Tier-17.5 followups are complete and the cat-data-model is in a fully steady-state.
Summary
Corrects 12 row-number references on
fact_multileg_option_eventsrows inddl/gold/06_cat_field_mapping.csvwhere the PDF-verified row number differs from the row originally claimed. All 12 corrections were identified during Tier 17.0's PDF verification pass and explicitly deferred to optional polish per Tier 17.5's CHANGELOG.Files changed
ddl/gold/06_cat_field_mapping.csv- 12 row-number correctionsCHANGELOG.md- Tier 18.4 entry + steady-state summaryCorrections in §5.2.2 (Multi-Leg Order Route Event)
sender_imiddestinationdestination_typerouted_order_idsessionroute_rejected_flagexch_origin_codepaired_order_idCorrections in §5.2.6 / §5.2.7
prior_order_idinitiatorleaves_qtycancel_qtyWhat's NOT in scope
10 SECTION_MISMATCH cases identified in Tier 17.0 remain intentionally unmodified. They represent legitimate alternative references between:
Both reference styles are spec-supported. The current §5.2.x style is meaningful in the multi-leg context and was preserved as a design decision.
Verification
test__ddl_parser.pypass.Post-followup state — STEADY
Test plan
test__ddl_parser.pyregression tests pass