OID4VCI plugin - Fix delete exchange-supported records (#460)

* Fix delete exchange-supported records * DCO Remediation Commit for timbl-ont <[email protected]> I, timbl-ont <[email protected]>, hereby add my Signed-off-by to this commit: c338c50 Signed-off-by: timbl-ont <[email protected]> * DCO Remediation Commit for timbl-ont <[email protected]> I, timbl-ont <[email protected]>, hereby add my Signed-off-by to this commit: c338c50 Signed-off-by: timbl-ont <[email protected]> * DCO Remediation Commit for timbl-ont <[email protected]> I, timbl-ont <[email protected]>, hereby add my Signed-off-by to this commit: c338c50 Signed-off-by: timbl-ont <[email protected]> * DCO Remediation Commit for Tim Bloomfield <[email protected]> I, Tim Bloomfield <[email protected]>, hereby add my Signed-off-by to this commit: 6695030 Signed-off-by: Tim Bloomfield <[email protected]> * DCO Remediation Commit for Tim Bloomfield <[email protected]> I, Tim Bloomfield <[email protected]>, hereby add my Signed-off-by to this commit: 212c7b3 Signed-off-by: Tim Bloomfield <[email protected]> * fix linting issue Signed-off-by: timbl-ont <[email protected]> --------- Signed-off-by: timbl-ont <[email protected]> Signed-off-by: Tim Bloomfield <[email protected]> Signed-off-by: Tim Bloomfield <[email protected]> Co-authored-by: Tim Bloomfield <[email protected]>
jamshale · May 22, 2024 · 7b44d16 · 7b44d16
1 parent e0074b7
commit 7b44d16
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 2 deletions.
diff --git a/oid4vci/oid4vci/public_routes.py b/oid4vci/oid4vci/public_routes.py
@@ -349,7 +349,8 @@ async def issue_cred(request: web.Request):
 
     if not pop.holder_kid:
         raise web.HTTPBadRequest(reason="No kid in proof; required for jwt_vc_json")
-
+
+    #note: Some wallets require that the "jti" and "id" are a uri
     payload = {
         "vc": {
             **(supported.vc_additional_data or {}),

diff --git a/oid4vci/oid4vci/routes.py b/oid4vci/oid4vci/routes.py
@@ -523,7 +523,7 @@ async def register(app: web.Application):
                 allow_head=False,
             ),
             web.delete(
-                "/oid4vci/exchange-supported/records/{cred_sup_id}",
+                "/oid4vci/exchange-supported/records/{supported_cred_id}",
                 supported_credential_remove,
             ),
         ]