Merge pull request #215 from jamshale/release-improvements

Improve release notes formatting
jamshale · Apr 30, 2024 · ffb8718 · ffb8718
2 parents 3f7960b + 092475a
commit ffb8718
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 7 deletions.
diff --git a/.github/workflows/create-release-pr.yaml b/.github/workflows/create-release-pr.yaml
@@ -321,7 +321,7 @@ jobs:
 
           upgraded_plugins=("${upgraded_plugins[@]}")
           count=${#upgraded_plugins[*]}
-          for i in $(seq 0 "$(("$count" - 1))" );
+          for i in $(seq 0 "$(("$count" - 2))" );
           do
               details=$(printf '%s %s \n\t - ' "$details" "${upgraded_plugins[$i]}")
           done

diff --git a/.github/workflows/create-release.yaml b/.github/workflows/create-release.yaml
@@ -106,15 +106,15 @@ jobs:
           # Get the release notes
 
           body=$(python repo_manager.py 4)
+          upgraded_plugins=($(python repo_manager.py 5))
+          details=$(printf 'Plugins upgraded this release: \n\t - ')
 
-          details=$(printf 'Plugins upgraded this release: \\n\\t\\t - ')
-
-          plugin_count=${#upgraded_plugins[@]}
-          for i in $(seq 0 "$(("$plugin_count" - 2))" );
+          count=${#upgraded_plugins[*]}
+          for i in $(seq 0 "$(("$count" - 2))" );
           do
-              details=$(printf '%s %s \\n\\t\\t - ' "$details" "${upgraded_plugins[$i]}")
+              details=$(printf '%s %s \n\t - ' "$details" "${upgraded_plugins[$i]}")
           done
-          details=$(printf '%s %s \\n' "$details" "${upgraded_plugins[-1]}")
+          details=$(printf '%s %s \n' "$details" "${upgraded_plugins[$count - 1]}")
 
           # Set the outputs