Switch autobuild OS to ARM runner #3470
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ann0see
force-pushed
the
autobuild/switchARM
branch
3 times, most recently
from
f6fba38 to
5bcfb63
Compare
ann0see
force-pushed
the
autobuild/switchARM
branch
from
5bcfb63 to
cc78e4c
Compare
|
ARM runners are considered public beta. I believe that if we don't remove the possibility to build on x86, it would be ok to merge this. But I'd also like to hear a general opinion. |
softins
reviewed
Jan 24, 2025
There was a problem hiding this comment.
I won't have time to test these builds for several days yet.
I've just looked at the build logs, and notice that native compilation only works for amd64 and arm64 architectures. Building armhf is still cross-compilation, but now on an arm64 runner. I assume that's expected.
Yes. That's expected. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short description of changes
Switches the build to ARM runners if an arm build is produced
CHANGELOG: Switch Linux ARM builds to be built on arm runners
Context: Fixes an issue?
Fixes: #3466
Does this change need documentation? What needs to be documented and how?
No
Status of this Pull Request
Tested on debian arm64 on a raspberry pi. armhf and arm64 both run. I'd like to have an independent test too (best on raspbian).
What is missing until this pull request can be merged?
External testing
Checklist