Enhance Navbar UI and Fix Dark Mode Background Layer for Improved Visual Consistency - #316
Open
zaaraf027-glitch wants to merge 2 commits into
Open
Conversation
…d theme toggle — closes janavipandole#266 - Replaced legacy dark-glassmorphism navbar with a modern floating white pill-shaped container (border-radius: 9999px, height: 72px, width: min(95%, 1600px)) centered 22px from the top of the viewport. - Added premium Apple-inspired soft shadow that deepens on scroll via JS .navbar-scrolled class. - Updated logo to FURNIX. with bold weight-800 type and #F57C00 orange dot. - Center nav links have 36px gaps, 16px/500 typography, janavipandole#222 color. - Active & hover links show #F57C00 text + 2px animated orange underline placed 8px below text with 300ms cubic-bezier transition. - Added thin vertical divider (1px, #EAEAEA, 28px height) between nav links and right-side action icons. - Right icon row: Filter, Search, User, Wishlist, Cart with 1.08x scale and #F57C00 color on hover, circular orange cart badge. - Dark mode: navbar pill uses elevated #1E212A surface with translucent border and deep drop shadow for equivalent contrast to light mode. - Removed extra dark background layer behind desktop nav links in dark mode by scoping [data-theme=dark] .navList to max-width: 899px only. - Ported React ThemeSwitch component (Sun/Moon) to vanilla JS/CSS: inline SVGs with cubic-bezier(0.34,1.56,0.64,1) spring animation, reads/writes localStorage theme, sets data-theme on html element. - Responsive: mobile drawer (max-width: 899px) slides in from right with ESC key support. - Full ARIA labels, aria-current, aria-hidden, aria-pressed, and keyboard focus rings applied across all pages. - Standardised header markup across all HTML pages.
|
Someone is attempting to deploy a commit to the janavipandole's projects Team on Vercel. A member of the Team first needs to authorize it. |
…olve style.css conflict
Author
|
@janavipandole I resolve the conflicts kindly merge it . |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This Pull Request improves the overall appearance and usability of the navigation bar while preserving all existing functionality.
The update focuses on creating a cleaner, more modern navigation experience and fixing a visual inconsistency that appeared in dark mode.
Changes Made
Problem Solved
Previously, the dark mode navbar displayed an extra dark rectangular background behind the navigation links, creating an inconsistent layered appearance.
This issue has been resolved by removing the unnecessary background styling while keeping the floating navbar intact.
Result
The navbar now provides:
Testing Performed
Checklist
Additional Notes
This Pull Request focuses exclusively on UI improvements and the dark mode visual fix. No application logic, routing, or functionality has been modified, ensuring a safe and non-breaking enhancement to the project's navigation experience.
Screenshot
Under ECSoC26