Bug: Lack of string sanitization on Promo Codes causes frustrating, s… - #393
Open
pradeep0153 wants to merge 1 commit into
Open
Bug: Lack of string sanitization on Promo Codes causes frustrating, s…#393pradeep0153 wants to merge 1 commit into
pradeep0153 wants to merge 1 commit into
Conversation
|
@pradeep0153 is attempting to deploy a commit to the janavipandole's projects Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #378.
Description
This PR resolves a highly frustrating UX bug within the checkout funnel where promotional codes were being silently rejected by the backend due to invisible whitespace or lowercase formatting, causing customers to abandon their carts in confusion.
Changes Made
<PromoCodeInput />component within the global<CartDrawer />. Discovered that the raw input string typed by the user was being dispatched directly to the backend validation API without any client-side sanitization.SUMMER20from an email, but accidentally copied a trailing space (yielding"SUMMER20 "), or if they manually typed it in lowercase ("summer20"), the strict matching logic rejected the payload. The frontend simply displayed a generic "Invalid Code" error.trim()operation to instantly strip all leading and trailing whitespace (which is invisible to the user), and atoUpperCase()operation to mathematically guarantee case-insensitive matching.Impact