Bug: Missing useEffect dependency array causes fatal infinite loop on… - #396
Open
pradeep0153 wants to merge 1 commit into
Open
Conversation
|
@pradeep0153 is attempting to deploy a commit to the janavipandole's projects Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #386.
Description
This PR resolves a catastrophic React lifecycle bug on the
/checkout/successlanding page where a missing dependency array caused a fatal infinite re-render loop, completely freezing the customer's browser tab immediately after they completed a purchase.Changes Made
<OrderConfirmation />component tree. Discovered a severe memory leak and infinite loop originating from auseEffecthook responsible for dispatching the "Purchase Successful" ecommerce payload to our analytics providers (Google Analytics / Segment).useEffect(() => { dispatchAnalytics(orderData) }). Because it explicitly lacked a dependency array, React forced the hook to run on every single render. Crucially, thedispatchAnalyticsutility was triggering an internal state update (e.g., setting ahasFiredflag). This state update triggered a re-render, which immediately triggered the hook again, locking the main thread in a violent, infinite loop until the browser tab crashed with an "Out of Memory" exception.useEffect(() => { dispatchAnalytics(orderData) }, []).Impact