Bug: Tapping a fabric swatch on mobile fails to trigger the image gal… - #407
Open
pradeep0153 wants to merge 1 commit into
Open
Bug: Tapping a fabric swatch on mobile fails to trigger the image gal…#407pradeep0153 wants to merge 1 commit into
pradeep0153 wants to merge 1 commit into
Conversation
|
@pradeep0153 is attempting to deploy a commit to the janavipandole's projects Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #404.
Description
This PR resolves a catastrophic state-desynchronization bug on the mobile Product Display Page (PDP) where selecting a new fabric swatch updated the local selector UI, but completely failed to update the primary product imagery, destroying user trust and causing massive cart abandonment.
Changes Made
<FabricSelector />and the primary<ProductGallery />on mobile breakpoints.<ProductGallery />was nested deep within a memoized (React.memo) mobile container that was failing to accurately track changes to theselectedVariantIdprop, effectively freezing the gallery's internal state to the default variant on mount.<ProductGallery />component to subscribe directly to the globaluseProductState()context hook. When a user taps a swatch, it mutates the global payload, forcing the gallery to bypass intermediate memoized components and re-render instantly.Impact