Code Quality: Resolve severe memory leaks by implementing strict clea… - #408
Open
pradeep0153 wants to merge 1 commit into
Open
Conversation
…nup functions on window event listeners
|
@pradeep0153 is attempting to deploy a commit to the janavipandole's projects Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #403.
Description
This PR executes a global architectural audit and refactoring of React lifecycle hooks to resolve a severe, compounding memory leak that was causing massive browser sluggishness and eventual "Out of Memory" crashes during long browsing sessions.
Changes Made
window.addEventListener('scroll')andwindow.addEventListener('resize').useEffecthooks upon component mount, but failing to provide the mandatoryreturn () => window.removeEventListener(...)cleanup function. Consequently, every single time a user navigated between products and these components remounted, a brand-new, redundant listener was permanently attached to the global window object, rapidly stacking up and suffocating the device's CPU with thousands of simultaneous, ghost scroll events.useEffectblock across the codebase that touches global APIs or intervals.addEventListeneris also passed toremoveEventListenerby utilizinguseCallbackwhere necessary.Impact