EPUB progress indicator #2784
Open
EPUB progress indicator #2784
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I found out that the percentage calculation could be done with the already included epub.min.js lib. This has the one downside that it has to build an index on load and therefore takes a few seconds to show the correct position when opening a book. However it means the other two libs I added before could be removed and the implementation is a lot simpler |
quarz12
force-pushed
the
progress_indicator
branch
from
a0a289a
to
4a366bd
Compare
…vious files, total bytesize. still needs implementation of bytesize of current file until CFI point.
TODO: resolve CFI to xml node
TODO:detect page change, display number
TODO: getPrev gives wrong values, design, testing
-cfi resolving is now done by that module, therefore removed validateChildNodes and adjusted cfiToXmlNode
quarz12
force-pushed
the
progress_indicator
branch
from
4a366bd
to
5e15cac
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this draft aims to implement #2765
My idea for achieving this is to compare the bytesize of all html files to the ones already read +the read percentage of the current book. while this does not give a 100% accurate representation as it counts the entire xml-tree instead of just the text fields , I think for this purpose it is more than good enough.