fix -mpopcnt compilation failure for v0.14 #185
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The problem arises from this bug in clang llvm/llvm-project#116278 which causes the following: ``` $ cc t.c -mpopcnt clang: error: unsupported option '-mpopcnt' for target 'arm64-apple-darwin24.4.0' $ cc t.c -mpopcnt -lpthread ``` The src/discover uses dune configurator, which always appends the C link flags from ocamlopt to the command line, and so the configurator erronously thinks that -mpopcnt will work. Since the dune configurator can't easily be overridden, this PR works around this specific link order issue by hand-calling the cc compiler from the discover binary. fixes janestreet#164 and janestreet#168 Signed-off-by: Yishuai Li <[email protected]>
github-iron
added
the
forwarded-to-js-devs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Propagate #180