used bevy_malek_async to make some async code more maintainable#38
Open
MalekiRe wants to merge 3 commits intojanhohenheim:mainfrom
Open
used bevy_malek_async to make some async code more maintainable#38MalekiRe wants to merge 3 commits intojanhohenheim:mainfrom
MalekiRe wants to merge 3 commits intojanhohenheim:mainfrom
Conversation
janhohenheim
approved these changes
Oct 26, 2025
Owner
janhohenheim
left a comment
janhohenheim
left a comment
There was a problem hiding this comment.
Minor nits, not much to say except: wow, this is much better <3
Comment on lines
+334
to
+335
| if let Some(_) = task.as_ref() { | ||
| info!("a navmesh save task is already running"); |
Owner
There was a problem hiding this comment.
Suggested change
| if let Some(_) = task.as_ref() { | |
| info!("a navmesh save task is already running"); | |
| if task.is_some() { | |
| warn!("Tried to save navmesh while another save is already in progress. Ignoring."); |
| })); | ||
| } | ||
| Some(_) => { | ||
| error!("a navmesh task is already running"); |
Owner
There was a problem hiding this comment.
Suggested change
| error!("a navmesh task is already running"); | |
| warn!("Tried to load scene while another navmesh task is already running. Ignoring"); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
( hopefully more maintainable )
let me know what you think.
Updated the Save and the get_navmesh_input.